search

ddialliance / ddimodel

Model for DDI Lifecycle
Other
14 stars 6 forks source link

Add Ordered attribute to properties which were implicitly ordered in the model #23

Closed DanSmith closed 3 weeks ago

DanSmith commented 11 months ago

In the prior XML schema of DDI Lifecycle, all properties were implicitly ordered within the XML.

In the new model, we must explicitly set the property to be Ordered if required. This was only done for Sequence so far, there are other properties that should have their Ordered set to true.

wlthomas commented 8 months ago

Should be completed by next release. XML assumed order. We need to mark these as ordered collections in CSV. "Sequence as ordered" is an example. We should find and mark these. Locate prior to making changes so we can move quickly on these.

wlthomas commented 8 months ago

I have provided a first pass of locations where order requirements should be evaluated. IssueDetails_No23.xlsx

wlthomas commented 8 months ago

Notes from TC meeting 2024-03-21 Not critical in short term (BETA version 2). Good to get multiple eyes on this.

wlthomas commented 5 months ago

Look at best way to include ordering (group types and schemes and supporting to hierarchical lists) (Dan) Groups/Schemes Instrument (ordered steps) Study/Group organization One class Obviously needing order Two those that might require ordering Known unknowns

Add those in and then test to see what was missed Need to devise a testing protocol that is needed to

wlthomas commented 1 month ago

IssueDetails_No23-annotated.xlsx I've noted those changes that were made in PR-48 Note that full Item and Complex type contents are listed and not all content required ordered designation. Not all were dealt with (that wasn't the expectation at this point) and some were added (see end of list). I have also added comments on a number of changes.

DanSmith commented 3 weeks ago

Addressed in #48