Add tests for write_json

ddionrails / collect_stata

Accumulate data from stata files and write it into an open format

BSD 3-Clause "New" or "Revised" License

0 stars 1 forks source link

Add tests for write_json #38

Open hansendx opened 5 years ago

hansendx commented 5 years ago

Please do not put the tests for collect_stata into a folder also called collect_stata. There is no other package to test in this project and it adds confusing redundancy.

But it's good, that you mirrored the module names of collect_stata with test_write_json.py. Just mirror the content of collect_stata into tests without an additional collect_stata folder.

afuetterer commented 5 years ago

Is this merge-ready?

mpahl commented 5 years ago

yes