search

ddiss / icyci

Safe and scalable continuous testing, without the bloat
GNU Affero General Public License v3.0
2 stars 1 forks source link

test: new failures with interactive notes editor #12

Closed ddiss closed 4 months ago

ddiss commented 4 months ago

It looks like an upstream git regression is causing the unit tests (and likely regular icyci jobs) to fail due to it now running GIT_EDITOR for input when an empty note is provided e.g.

$ echo -n|git hash-object -w --stdin --no-filters
e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
$ git notes --ref refs/notes/empty add --allow-empty -C e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 HEAD

In previous versions of git this used to add an empty note, but this now causes git to start GIT_EDITOR. I'm highly suspicious of upstream git commit 90bc19b3ae ("notes.c: introduce '--separator=' option") and the way it changes the d->given setting.

ddiss commented 4 months ago

Unfortunately I think the simplest workaround will be to set GIT_EDITOR to true for the git notes add calls. I'll raise it with upstream git, but even if it's acknowledged as a regression, a fix would still take some time to filter through to distros.

ddiss commented 4 months ago

I've proposed an upstream git fix for the regression via https://lore.kernel.org/git/20240725144548.3434-1-ddiss@suse.de/