search

ddksr / HackerGameJS

This is a hacker game for children which should help them learn computer science concepts like computer networks, computer architecture, security etc.
GNU General Public License v2.0
2 stars 1 forks source link

Repository layout #33

Closed kernc closed 10 years ago

kernc commented 10 years ago

I find directory names dev and ext quite odd, and I can't find any recommendations to this convention. Instead, I find src and lib much more standard. What's in dev/ext_dev, btw?

Additionally, dev/ass is kind of inappropriate as well. It's best practice to avoid using short notations and acronyms unless they are accepted standard. img and lang are fairly standard and obvious; ass not so much.

Finally, you don't put binary blobs under version control unless they are essential and irreplaceable. hgjs-latest.zip and the whole releases/* are completely extraneous. You have git-tagged your releases; they are always available for download: https://github.com/ddksr/HackerGameJS/archive/{TAG}.zip

ddksr commented 10 years ago

OK, I totally agree. I don't remember what inspired me to do this that way, I thought it were some JS projects but I was wrong.

Yes, the binary in VC was a stupid idea but there is a problem. I know the repository is available trough that link but what if I didn't want the user who wishes to have the HG release to also download all the scripts etc. Also, the directory layout is adjusted for development and not for production. I also didn't want to VC production files. Any idea?

ddksr commented 10 years ago

O, ext_dev are external libs only needed for development and not for the production version. As you probably noticed, the development version includes tests which I have to purge out.

ddksr commented 10 years ago

This issue solved with latest commits on branch develop.