search

ddn / spotify-member-music

Plays music from multiple playlists pulled via REST request
GNU General Public License v3.0
1 stars 2 forks source link

Tracks that don't load to due non-US #2

Open ddn opened 11 years ago

ddn commented 11 years ago

Example: spotify:track:4CDjDgDZ6OQ1ZwqNFc9wOd

I'm not seeing the issue on my Mac dev side, but I am still on Win32...for some reason.

jtgraphic commented 11 years ago

I'll check it out.

ddn commented 11 years ago

Bad example. that one is causing another issue.

jtgraphic commented 11 years ago

Ha, alright. Well we can figure that issue out as well.

ddn commented 11 years ago

They broke something in this latest update. I can crash the app with one of these URLs now.

jtgraphic commented 11 years ago

So... issue resolved, or no? I noticed you decremented the API version.

ddn commented 11 years ago

Got it. spotify:track:4CDjDgDZ6OQ1ZwqNFc9wOd

jtgraphic commented 11 years ago

Ah - apparently I'm just impatient ;)

jtgraphic commented 11 years ago

So we basically just need to skip files like these?

ddn commented 11 years ago

Yes, but the only way I've found to skip them is by detecting a weirdness in the change event, or failure to load. And that doesn't seem to be flawless. Their API is messy.

jtgraphic commented 11 years ago

I'll hack at it.

jtgraphic commented 11 years ago

Fairly sure I've got it.

jtgraphic commented 11 years ago

I'm going to do a bit more testing and if it's working I'll submit a PR.

ddn commented 11 years ago

I'm still seeing this error occasionally on the production machine

jtgraphic commented 11 years ago

Crap - did you happen to catch the tracks?

ddn commented 11 years ago

No, I'm not sure but if it's logging the correct tracks to the inspector I might be able to next time.

jtgraphic commented 11 years ago

Not logging the right tracks is an actionable thing. I'll take a look at that.

ddn commented 11 years ago

Latest:

Last time it hung on a track, I looked at the last 3 things logged to the inspector. It went

Failed: spotify:track:4CDjDgDZ6OQ1ZwqNFc9wOd Loading: spotify:track:4k0DIJNg6xTfEu80VTIW0g Loaded: spotify:track:4k0DIJNg6xTfEu80VTIW0g

I don't recall the Pitbull track being loaded in Spotify, and it definitely stopped playback. I can't verify that the Failed one is the one that hung it.

I haven't had time to do any investigating on it.

jtgraphic commented 11 years ago

I can work with that.