search

ddnet-insta / ddnet-insta

A teeworlds instagib (grenade/laser capture the flag/death match/catch) mod based on DDRaceNetwork (gctf/ictf/idm/gdm/zcatch)
https://ddnet.org
Other
7 stars 3 forks source link

the ``!restart 1`` command breaks ChillerDragon/ddnet#pr_07_client skins #92

Closed ChillerDragon closed 7 months ago

ChillerDragon commented 9 months ago

As soon as the vote passes the current ddnet pr to add 0.7 client support to ddnet https://github.com/ddnet/ddnet/pull/5949 shows the default skin for it self. The it keeps showing that the entire warmup and it never gets fixed not even on round start.

Vanilla clients work fine so this is clearly a bug in https://github.com/ddnet/ddnet/pull/5949 and in ddnet-insta. But it should be fixed in both to implement the protocol correctly.

Map changes work fine and interestingly so does the rcon restart 1 or reload command.

ChillerDragon commented 7 months ago

The ddnet 7 client had a bug that would delete skin state on vote end. ddnet-insta uses votes for the bang commands. That is fine. There is no need to change ddnet-insta any correctly implemented 0.7 client should handle that just fine.