search

ddnet / ddnet

DDraceNetwork, a free cooperative platformer game
https://ddnet.org
Other
593 stars 421 forks source link

Synchronising envelopes doesn't work #1318

Closed 12pm closed 1 year ago

12pm commented 6 years ago

Animations with checked "Synchronised" option don't reset on going through start.

heinrich5991 commented 6 years ago

This is expected. They're synchronized between all clients. It was some preparing work for the teeuniverse stuff, so it could be reverted — but I think we should rather render it the same way as it is rendered in vanilla maps.

12pm commented 6 years ago

Don't you have synchronization between all clients with the option turned off already? Since teeuniverse is not a thing anymore, it would be nice to restore the old behavior.

heinrich5991 commented 6 years ago

Don't you have synchronization between all clients with the option turned off already?

No. If you have the option turned off, the animation is relative to the join time.

12pm commented 6 years ago

https://github.com/ddnet/ddnet/issues/1214 Maybe default sync it to server time and make it optional to sync it to race time? At least for DDRace maps, reseting it on joining doesn't have any advantage over reseting it on server start really.

heinrich5991 commented 6 years ago

Mh. It's probably hard to properly synchronize with race time: What happens before you start the race? What happens in the moment you start the race? I'd guess the animation flickered before we separated race time from game time, which doesn't sound particularly polished.

heinrich5991 commented 6 years ago

Maybe it could wait in an unanimated state until the race starts.

fokkonaut commented 6 years ago

dont sync on race time, sync it on server time so every client will always see the same animation on the selected quad.

Learath2 commented 5 years ago

Is this still wanted?

fokkonaut commented 5 years ago

ofc

12pm commented 5 years ago

yes

heinrich5991 commented 5 years ago

dont sync on race time, sync it on server time so every client will always see the same animation on the selected quad.

I believe this is the case today if you select "synchronized".

Is this still wanted?

I think synchronizing on race time is a bad idea because of the reason outlined above.

Chairn commented 2 years ago

Relevant PR: https://github.com/ddnet/ddnet/pull/602

One way could be to synchronize every game elements to race time which would also allow 100% reproducible run.

heinrich5991 commented 1 year ago

Not synchronizing envelopes to race time but to server time is intended.