ddnet / ddnet

DDraceNetwork, a free cooperative platformer game
https://ddnet.org
Other
589 stars 417 forks source link

[GUI/SUPER] Key #470

Closed FallenKN closed 3 months ago

FallenKN commented 8 years ago

Since we are ignoring those inputs, this will cause some useless buttons under some linux-systems.(appeared on Cinnamon-Desktop) Whenever I press LGUI/LSUPER my System-Menu pops up without any accessibility, because DDNet still is stealing the focus (Mouse&Keyboard-Inputs).

bug

What about assigning LGUI/LSUPER to minimize?

def- commented 8 years ago

How was this in DDNet 9.3.1?

FallenKN commented 8 years ago

In 9.3.1 nothing happened default by pressing, but atleast I was able to bind minimize to it

def- commented 8 years ago

I'm still wondering why this behaviour exactly changed from SDL1.2 to SDL2. For your specific case we could have keyboard grab, then no key inputs would reach the window manager.

FallenKN commented 8 years ago

I don't really know either, but I rather have this bug instead of not being able to 'alt-tab'. To tabbing out under Linux with SDL2 was one of the biggest benefits.

def- commented 8 years ago

Can you compile from git? Could you check if this fixes your issue? https://git.io/vwA6D

Otherwise we could probably also handle SDL_WINDOWEVENT_ENTER and SDL_WINDOWEVENT_LEAVE.

FallenKN commented 8 years ago

sadly this is not solving the problem, it only encounters in fullscreen-mode by the way

//Edit: it works now for the browser but not ingame, just sometimes

def- commented 8 years ago

Try using borderless window instead of fullscreen, it's better anyway.

FallenKN commented 8 years ago

while trying to play with borderless window I experienced some other bugs, for example I can activate borderless window and fullscreen at the same time and with much MouseDPI the mouse can leave Teeworlds while playing without input grab.

def- commented 8 years ago

That's always been the case to my knowledge.

Tardo commented 8 years ago

@FallenKN you can use RIGHT+LEFT Mouse click at the same time in Linux Mint? you know how disable this bind in the system? by default RIGHT+LEFT = Middle Click, but if disable it only disabled the action not the bind :/

Sry for offtopic :S

FallenKN commented 8 years ago

@CytraL This was already disabled, anyways I switched to another Distro.

My Reason to create this "Topic" was to assign minimize to LSUPER by default not more.

rffontenelle commented 8 years ago

For the record, I use Arch Linux + GNOME 3.20 and I play in borderless window mode. Since DDNet version 10.0.1, the Super key won't work for me to call the GNOME's Activity Overview (equivalent of Start Menu of Windows). I also reported this in the forum.

def- commented 8 years ago

I tried inp_ignored_modifiers 1024 (f1) and SDL_HINT_GRAB_KEYBOARD 0 (in backend.cpp) but neither worked. I guess this is an issue with all SDL2 programs and might even be intentional? Maybe you can change a program's keyboard grab settings with gnome itself.

Robyt3 commented 3 months ago

Is this still an issue with recent versions of the client? @FallenKN @rffontenelle

rffontenelle commented 3 months ago

For me, in Arch Linux + GNOME 46 + DDnet 18.4, i lt works as expected: pressing Super key will open Activity Overview (GNOME's "start menu") with mouse and keyboard responding normally as any other window.

Robyt3 commented 3 months ago

Thanks for checking, @rffontenelle.

I'll consider this fixed with recent client versions until we get another report.