search

ddnet / ddnet

DDraceNetwork, a free cooperative platformer game
https://ddnet.org
Other
589 stars 417 forks source link

Dummy hammerfly laser technique broken in 16.1? #5373

Open def- opened 2 years ago

def- commented 2 years ago

Toasty Loaf reports:

I want to downgrade because the dummy hammerfly laser technique was broken in the new update. When you double tapped hammerfly in the old version, your dummy would stay on laser, so you could continue to self laser. Now, every time you double tap hammerfly, the dummy will laser you but after will switch weapons randomly.

murpii commented 2 years ago

What version? I've tried multiple builds and get the same behavior on all of them.

C0D3D3V commented 2 years ago

He should make a video I do not understand what technique he is refering to but, you can do auto laser shots in latest master. https://youtu.be/rB_TZPvIeCg

But if you do it with 16.1 on a latest master server you will probably get minor prediction errors (I tested it, it still works but looks sometimes like wrong timing), because of: https://github.com/ddnet/ddnet/pull/5032 as we use now a new input handling that is in master fixed here: https://github.com/ddnet/ddnet/pull/5320

bananaman1 commented 2 years ago

Any way to post a demo? I can't seem to post a .demo here.

def- commented 2 years ago

I am using 16.1 native app, not steam

Blmap4_2022-06-08_13-13-03.demo.zip

murpii commented 2 years ago

cl_dummy_restore_weapon 1 fixes this

I am using 16.1 native app, not steam

Blmap4_2022-06-08_13-13-03.demo.zip

murpii commented 2 years ago

@def- He messaged me and we tried a number of things, but without success. A clean settings file, multiple dummy settings. Whatever it is, it's most likely due to performance. Hes using a laptop, quite a old one aswell, or atleast not very powerful.

C0D3D3V commented 2 years ago

Would be good if he would try the latest master build (or nightly), if it with that version works, then we can be kind of sure it is the change that I mentioned above.

bananaman1 commented 2 years ago

I have tried 16.0.3, 16.1, and nightly build. It worked briefly with 16.0.3 then proceeded to stop working.

bananaman1 commented 2 years ago

Please tell me if y'all can see my messages. GitHub flagged my account for some reason, even though I have never used GitHub.

murpii commented 2 years ago

He tried older builds and the nightly, no changes.

Learath2 commented 2 years ago

Smells like a race/UB, such a hard to investigate one as well. Not quite sure what we could do here. I'll try to investigate the entire codepath see if there is anything suspicious.

bananaman1 commented 2 years ago

It is a weird one. It did start happening when I downloaded the most recent update, but going back an update and also trying nightly didn't fix it. It's never been an issue before so I have no clue.

murpii commented 2 years ago

cheeser0613 just reported this aswell. Happened whilst playing Stronghold and apperantly fixed itself somehow after some time.

C0D3D3V commented 2 years ago

On Stronghold there is no laser. So I probably do not understand whats the technique they are using. Maybe he used gun.

It is probably strongly related to the shotgun bug. (Thats what I told at the beginning. Because we are handeling inputs now one tick earlier). We could test it, if you set prediction margin to 300 (or 200) and try the technique on our servers but with 16.1 client.

murpii commented 2 years ago

On Stronghold there is no laser. So I probably do not understand whats the technique they are using. Maybe he used gun.

It is probably strongly related to the shotgun bug. (Thats what I told at the beginning. Because we are handeling inputs now one tick earlier). We could test it, if you set prediction margin to 300 (or 200) and try the technique on our servers but with 16.1 client.

The title is abit misleading. This bug happens when turning dummy hammerfly on/off in rapid successions. Whenever dummy hammerfly is turned off, the tee changes to a random weapon, regardless if cl_dummy_restore_weapon is set to 1 or 0. (becomes a problem when using deepfly aswell)

C0D3D3V commented 2 years ago

the tee changes to a random weapon, regardless if cl_dummy_restore_weapon is set to 1 or 0

Does this also happen on master/nightly, could you reproduce it, or do we still only have the reports?

murpii commented 2 years ago

the tee changes to a random weapon, regardless if cl_dummy_restore_weapon is set to 1 or 0

Does this also happen on master/nightly, could you reproduce it, or do we still only have the reports?

Only reports, cheeser0613 says he is able to reproduce this, but I didn't quite understand how. You can message both people on the DDNet discord ^^