ddnet / ddnet

DDraceNetwork, a free cooperative platformer game
https://ddnet.org
Other
589 stars 417 forks source link

Tele/Switch free slot finder doesn't update when placing tiles #5908

Open BannZay opened 2 years ago

BannZay commented 2 years ago

Steps to reproduce:

  1. Create new map in map editor and add tele layer.
  2. Select tele number 1.
  3. Draw CFRM tile (id 63 or 31) to any place.
  4. Change tele number to 2.
  5. Change tele number back to 1. (last two steps has to be done in order to update number background color).
  6. Check tele number background color for tele 1.

Expected: tele number is green (free)

Actual: tele number is red (used)

Reason: the game (as far as I know) does not use the tele number for CFRM tiles in any way so they should not be counted as tele tile for free slot finder. CFRM tele number is also not being rendered neither in game or in editor.

P.s.: just additional suggestion - if this is going to be fixed, would be great to also update (green/red) colors on "picker displayed" additionally to "tele number changed" event so you could skip step 4 and 5 if possible.

Marmare314 commented 1 year ago

P.s.: just additional suggestion - if this is going to be fixed, would be great to also update (green/red) colors on "picker displayed" additionally to "tele number changed" event so you could skip step 4 and 5 if possible.

These steps were not necessary for me, so #6421 does not adress this.