ddnet / ddnet

DDraceNetwork, a free cooperative platformer game
https://ddnet.org
Other
589 stars 417 forks source link

memory leak with entities #636

Closed Henningstone closed 7 years ago

Henningstone commented 7 years ago

Every time you switch between gamemodes while using entities, memory is being leaked as the image for the entities is reloaded every time you go on a different gametype, but never unloaded. Look at the code, you'll immediately see what I mean:

https://github.com/ddnet/ddnet/blob/master/src/game/client/components/mapimages.cpp#L112

heinrich5991 commented 7 years ago

The line referenced was src/game/client/components/mapimages.cpp, line 112. @Henningstone Please press y before copying the link from GitHub, this will create a permanent link. Your link is already outdated due to the fix. ^^

Henningstone commented 7 years ago

Oh, didn't know that you could press y there! Thanks for pointing it out, @heinrich5991