search

ddnguyen / slimmath

Automatically exported from code.google.com/p/slimmath
0 stars 0 forks source link

In Vector3 Equals methods are missing a comparison for the z field #1

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
This is the current code

return (value1.X == value2.X && value1.Y == value2.Y); 

I think it should be 

return (value1.X == value2.X && value1.Y == value2.Y && value1.Z == 
value2.Z);

Original issue reported on code.google.com by FrrrS...@gmail.com on 11 Feb 2010 at 8:37

GoogleCodeExporter commented 8 years ago 
Ah yes, good catch. I guess my unit test wasn't the greatest for detecting that 
sort
of thing.

Original comment by Mike.Popoloski on 12 Feb 2010 at 1:07

GoogleCodeExporter commented 8 years ago 
Fixed in r12.

Original comment by Mike.Popoloski on 12 Feb 2010 at 4:40