search

ddollar / foreman

Manage Procfile-based applications
http://ddollar.github.com/foreman
MIT License
6.03k stars 631 forks source link

Doesn't follow forks? #708

Open haydenflinner opened 6 years ago

haydenflinner commented 6 years ago

I have a procfile that looks like this: 

controller: ./gtcontroller
store1: sleep 1; ./gtstore -p $PORT
store2: sleep 1; ./gtstore -p $PORT
client: sleep 2; ./gtclient

When I run it with Foreman, the gtstores are still visible with pgrep store, and their pids are a little bit higher than the PIDs that Foreman claims to have seen.

When I run the same procfile with honcho, everything works fine; the processes are killed at the end as expected.

andrewmcodes commented 5 years ago

@haydenflinner is this still an issue?

haydenflinner commented 5 years ago

Well, did you do anything that would have fixed it? I don't see anything in the commit history since I posted it that would have helped. Although in hindsight one workaround is

store1: bash -c "sleep 1; ./gtstore -p $PORT"

andrewmcodes commented 5 years ago

I’m just trying to help out the maintainer by doing some issue triage 🙂

dentarg commented 1 year ago

Maybe due to https://github.com/ddollar/foreman/issues/779? That issue has been addressed in overman, a foreman fork, see https://github.com/ddollar/foreman/pull/780#issuecomment-1294980165

haydenflinner commented 1 year ago

This would probably be the perfect fix. Running in separate process group and killing that is perfect. I forgot about this tool but may need it again in the near future, I'll use your fork if so, that is the proper way to do it!