ddollar / foreman

Manage Procfile-based applications
http://ddollar.github.com/foreman
MIT License
6.04k stars 633 forks source link

Bump Thor dependency #725

Closed radar closed 5 years ago

radar commented 5 years ago

When attempting to upgrade my app to rails 6.0.0.beta1 today, I came across this:

Bundler could not find compatible versions for gem "thor":
  In Gemfile:
    foreman was resolved to 0.85.0, which depends on
      thor (~> 0.19.1)

    rails (~> 6.0.0.beta1) was resolved to 6.0.0.beta1, which depends on
      railties (= 6.0.0.beta1) was resolved to 6.0.0.beta1, which depends on
        thor (>= 0.20.3, < 2.0)

I believe this is caused by foreman's thor dependency being behind what railties expects.

Bumping this version and running foreman's tests on my own machine did not show up any strangeness, so I think it is probably safe to do.

radar commented 5 years ago

Build failure caused by rubygems incompat with that version of Ruby. Perhaps consider removing support for older Ruby versions?

ddollar commented 5 years ago

Please remove foreman from your Gemfile and install it as a system-level dependency (see the README)