Add reason for why developers might not include in Gemfile

ddollar / foreman

Manage Procfile-based applications

http://ddollar.github.com/foreman

MIT License

6.02k stars 632 forks source link

Add reason for why developers might not include in Gemfile #728

Closed abraham closed 5 years ago

abraham commented 5 years ago

It seems the message has changed over the years but originally stems from this comment. Instead of flatley rejecting the idea, specify why dev might want to avoid it so they can decide for themselves.

abraham commented 5 years ago

Fixed

keithbro commented 5 years ago

I also agree it would be useful to provide some context. But even with this PR - I'm still not clear on the risk of adding to the Gemfile. Would it be possible to get some further explanation please?

ddollar commented 5 years ago

I highly suggest that you do not include foreman in your Gemfile. I've written up my reasoning here:

https://github.com/ddollar/foreman/wiki/Don't-Bundle-Foreman

abraham commented 5 years ago

That doesn't resolve the purpose of this PR but 🤷.

ddollar commented 5 years ago

Added the link to the README here: https://github.com/ddollar/foreman/commit/14bf2532500849ab076cb7512f05a32f815361d6