search

ddollar / foreman

Manage Procfile-based applications
http://ddollar.github.com/foreman
MIT License
6.02k stars 632 forks source link

Update ruby versions to latest in Travis and update Thor to latest version in Gemfile #745

Closed Jesterovskiy closed 3 years ago

ddollar commented 4 years ago

I would accept an update to the Ruby versions but updating the thor dependency would put it out of sync with the vendored thor.

Jesterovskiy commented 4 years ago

@ddollar ok, I'll revert Thor changes, one moment

ddollar commented 4 years ago

Please update this PR to be only an update to the Ruby versions and I would be happy to merge. Thanks!

Jesterovskiy commented 4 years ago

@ddollar done! Sorry for a big delay)

Jesterovskiy commented 4 years ago

@ddollar do you have time to review it again?)

kkohrt commented 3 years ago

@ddollar & @Jesterovskiy -- There is a ruby 2.7.2 out there, https://www.ruby-lang.org/en/downloads/releases/ But I think it would be great to get a least one 2.7.* test merged in, yes? Anything I can do to help?

micwoj92 commented 3 years ago

There is even ruby 3.0 now :o does anyone know if this is ruby 3 compatible?

Jesterovskiy commented 3 years ago

@kkohrt @micwoj92 almost a year ago I made my changes but @ddollar gone somewhere =(

Jesterovskiy commented 3 years ago

I think, I can close it now, because nobody cares