search

ddollar / foreman

Manage Procfile-based applications
http://ddollar.github.com/foreman
MIT License
6.01k stars 630 forks source link

Foreman does not terminate child process #779

Open baelter opened 3 years ago

baelter commented 3 years ago

Same issue as https://github.com/ddollar/foreman/issues/628

Procfile:

worker: ruby test.rb

test.rb

pid = Process.spawn("sleep 100")
Process.detach(pid)
sleep

Steps to repoduce:

  1. $ foreman start
  2. $ kill <foreman-pid>
  3. Spawned process is still running
dentarg commented 3 years ago

I think https://github.com/ddollar/foreman/pull/723 addresses this issue. I rebased that branch against latest master, feel free to try it out: https://github.com/dentarg/foreman/tree/pgroup

dentarg commented 1 year ago

I forked foreman and merged #780 (#723 but rebased) and released the fork as overman: https://github.com/spinels/overman, https://rubygems.org/gems/overman, https://github.com/ddollar/foreman/pull/780#issuecomment-1294980165

jdelStrother commented 1 year ago

@dentarg thanks for overman, I've replaced foreman with it in our dev setup.