ddonahue99 / gerrit-slack

Gerrit integration for Slack
14 stars 13 forks source link

Add regex and fix tests #5

Open hannahbot-zz opened 9 years ago

hannahbot-zz commented 9 years ago

This commit adds regular expression capability, and fixes the update_spec.rb and channel_config_spec.rb

I found channel.regexes.any?{|regex| update.regex_matches?(regex)} is too broad - it will ping regardless of owner in all the channels. The channel_config_spec.rb is very explicit to cover all case statements, but I would like to clean it up in another commit.