ddopson / underscore-cli

Command-line utility-belt for hacking JSON and Javascript.
Other
1.72k stars 83 forks source link

Use fixed Commander version (cannot find module) #29

Closed tyom closed 10 years ago

tyom commented 10 years ago

The newer version that is installed with * in package.json breaks map, reduce and other commands. Using the version specified in @ddopson info in README fixes the issue.

Fixes #26 & #28.

ddopson commented 10 years ago

Thanks for fixing this!

reklis commented 10 years ago

:sparkling_heart:

ddopson commented 10 years ago

lol. In my email, that just shows up as ": sparkling_heart"

reklis commented 10 years ago

this regressed somehow. on a new machine I installed underscore-cli and it put commander@2.3.0 A quick look at package.json reveals this:

"dependencies": { "underscore": ">= 1.3.3", "underscore.string": "", "commander": "", "coffee-script": "", "JSONSelect": "", "msgpack": "*" },

ddopson commented 10 years ago

Odd. Checking package.json from the repo, I just confirmed that it is set to "1.0.5".

I think what's happening is you must have installed from NPM?

I need to push an update there. Lemme go do that.

On Mon, Oct 6, 2014 at 2:26 PM, Steven Fusco notifications@github.com wrote:

this regressed somehow. on a new machine I installed underscore-cli and it put commander@2.3.0 A quick look at package.json reveals this:

"dependencies": { "underscore": ">= 1.3.3", "underscore.string": " ", "commander": "", "coffee-script": " ", "JSONSelect": "", "msgpack": "*" },

— Reply to this email directly or view it on GitHub https://github.com/ddopson/underscore-cli/pull/29#issuecomment-58102126.

ddopson commented 10 years ago

Ok, I pushed version 0.2.18 which should have your fix in it.

reklis commented 10 years ago

a true gentleman :tophat: