search

ddotta / parquetize

R package that allows to convert databases of different formats to parquet format
https://ddotta.github.io/parquetize/
68 stars 4 forks source link

feat: add fst_to_parquet function #35

Closed ddotta closed 1 year ago

ddotta commented 1 year ago

Hi @nbc ,

This PR simply adds a fst_to_parquet function.

Close #29

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (81f4337) 99.66% compared to head (643c995) 99.67%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #35 +/- ## ======================================= Coverage 99.66% 99.67% ======================================= Files 15 16 +1 Lines 302 311 +9 ======================================= + Hits 301 310 +9 Misses 1 1 ``` | [Impacted Files](https://codecov.io/gh/ddotta/parquetize/pull/35?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Damien+Dotta) | Coverage Δ | | |---|---|---| | [R/fst\_to\_parquet.R](https://codecov.io/gh/ddotta/parquetize/pull/35?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Damien+Dotta#diff-Ui9mc3RfdG9fcGFycXVldC5S) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Damien+Dotta). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Damien+Dotta)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

nbc commented 1 year ago

Hi @ddotta,

It's perfect for me.

I wonder if fst package must be in Imports or in Suggest with a error "fst must be installed to use this method" when you call fst_to_parquet without the fst installed.

And I was wandering in other files, I find a bug in csv_to_parquet that has two arguments compression and compression_level never passed to write_parquet_at_once (we only pass ellipsis).

ddotta commented 1 year ago

Thanks @nbc for the review! I included the fst package in the Imports, I had simply forgotten to add the importFrom statement

ddotta commented 1 year ago

And I was wandering in other files, I find a bug in csv_to_parquet that has two arguments compression and compression_level never passed to write_parquet_at_once (we only pass ellipsis).

Ok good point. I'm opening an issue to keep it in mind. See #36