search

ddotta / parquetize

R package that allows to convert databases of different formats to parquet format
https://ddotta.github.io/parquetize/
68 stars 4 forks source link

Adds argument `read_delim_args` to `csv_to_parquet` #49

Closed nikostr closed 1 year ago

nikostr commented 1 year ago

This is an attempt to provide greater flexibility in csv_to_parquet, allowing users to be explicit about which delimiters to use, or if comments are present in the csv etc. I first considered simply adding the delim and comment args to csv_to_parquet as this would have been very straight forward, but instead attempted this more general solution.

This is the first time I contribute to an R packed, and I have not used testthat or roxygen2 previously. Do let me know if there are any additional changes that need to happen.

ddotta commented 1 year ago

Thanks a lot @nikostr for this PR ! It seems ok for me. @nbc do you want to take a look ?