ddragosd / python-rclone

Python module for rclone
Apache License 2.0
80 stars 17 forks source link

Fix compatibility with Windows #5

Open ditsuke opened 3 years ago

ditsuke commented 3 years ago

Replaced the usage of tempfile's NamedTemporaryFile() method with the mkstemp() method for the generation of the temp rclone config. This method requires the wrapper to remove the file manually but allows it to work on Windows.

This fixes #4.

Ethycs commented 3 years ago

This would be very useful. Thanks alot!

mohdsabahat commented 2 years ago

Looks like his commit doesn't reflect in the main repository? Or i am doing something wrong?

ditsuke commented 2 years ago

Looks like his commit doesn't reflect in the main repository? Or i am doing something wrong?

Hi @mohdsabahat, apologies I couldn't respond earlier. This is an unmerged pull request, but if you want to use it you could use the master branch from my fork.