search

ddrillini / Simply-Love-SM5

A fork of Simply Love, to hold DDRIllini's tweaks.
http://ddrillini.club
MIT License
6 stars 2 forks source link

Initial work done on forcing cmod for RIP11, bug noted in comments #10

Closed mgpixel closed 5 years ago

mgpixel commented 5 years ago

Right now currently works if they go into the options menu and accidentally pick cmod, not for the case where they just pick a song. Noted unintentional behavior for now, mainly trying to find where it loads the options from if a song is picked only.

ianklatzco commented 5 years ago

@andrewipark we'll make a separate rip11 branch for this, most likely.

andrewipark commented 5 years ago

Alternatively, if you don't want to track that down, you could move the "force CMod" part of the code to gameplay init

mgpixel commented 5 years ago

Hi, updated it to not force cmod on players, instead just sending them back to the options screen. There's a bug with if a player has cmod and picks a no cmod song not wanting the options screen, it'll go to the options screen but then sound will stop playing until in gameplay screen or back to music select screen. Am not sure how to get text to pop up properly for "Exit" without modifying the config file and having it always there, so players might be confused about why they're looping through the options screen. Any ideas?

ianklatzco commented 5 years ago

but then sound will stop playing until in gameplay screen This doesn't sound like a problem. Kinda disconcerting to players, tho.

Am not sure how to get text to pop up properly for "Exit" without modifying the config file and having it always there, so players might be confused about why they're looping through the options screen.

Can you clarify?

mgpixel commented 5 years ago

So if they never change cmod, it'll keep looping them back to options without telling them why (unless they go back to menu). I wanted the exit to change text from nothing to telling them to choose xmod/mmod or something like that, unless you tell everyone/show them expected behavior

ianklatzco commented 5 years ago

i see. it should be easy to hack text that conditionally says "no cmod allowed!!!" above the cmod indicator.

ianklatzco commented 5 years ago

yolo we need it hope it doesn't bug the fuck out of things. andrew, download a zip of rip11 branch, load it on all the cabs

ianklatzco commented 5 years ago

changing the displayname of the theme fucks w all the themeprefs.

ianklatzco commented 5 years ago

maybe just simply love options.

ianklatzco commented 5 years ago

yeah, all the themeprefs (are simply love options just themeprefs or are they stored elsewhere?). the fix is to dupe the themeprefs in stepmania's profile folder (.stepmania-5.1/ThemePrefs.ini). specifically dupe this 

[Simply Love]
blah
blah

inside the file and rename the first line to RIP11 or whatever you set the theme's displayname to in INSTALL/Themes/Simply Love/ThemeInfo.ini.

this is a pain in the ass for relatively little gain. i don't want to deploy this on three cabs tomorrow, the total amount of time would exceed the time we'd save.

however, this is a useful feature. we can polish it a little more and make it into a themepref after the tournament.

specifically, if NO CMOD (any variation of caps) is in the title or subtitle, prevent it from exiting and pop some text that says don't use cmod.

mgpixel commented 5 years ago

I'll look into it later, merge/use the other PR since I forgot I changed something in my testing that created a bad bug.