If you're in ECFA mode, "disable decents and wayoffs" actually disables greats and decents.

ianklatzco commented 5 years ago

Looks like it's here: https://github.com/ddrillini/Simply-Love-SM5/blob/aaee3d038867862fcd751d6f4db9166f286829a1/Scripts/SL-PlayerOptions.lua#L292

Andrew:

With 3d62425 it is now possible to get the OptionsRow to dynamically change the displayed option strongs, but still have them map to the same choices engine side. Unfortunately, this does not apply to the (promptly localized) name of the OptionRow.

I wonder if binding (yet another, ugh) property in the table for a given OptionRow will work:

-- in a given OptionRow
name = function() return "do stuff here" end
-- insert this into OptionRowDefault to replace line ~452
if Overrides[name].NameFunction then
    self.name = Overrides[name].NameFunction()
else self.name = name end

andrewipark commented 5 years ago

I need to overhaul some of the way this is laid out anyways... it was fine until I added my thing and now the if-else structure is driving me insane.

quietly-turning commented 5 years ago

Fixed in https://github.com/dguzek/Simply-Love-SM5/commit/b41cfdd366bd5e49eea33743723c9a8f631ee241.

andrewipark commented 4 years ago

:heavy_check_mark:

quietly-turning commented 4 years ago

Thank you for closing this.

ddrillini / Simply-Love-SM5

If you're in ECFA mode, "disable decents and wayoffs" actually disables greats and decents. #26