search

ddrillini / Simply-Love-SM5

A fork of Simply Love, to hold DDRIllini's tweaks.
http://ddrillini.club
MIT License
6 stars 2 forks source link

move more things into theme-side OptionRows #8

Closed andrewipark closed 5 years ago

andrewipark commented 5 years ago

More of a personal thing as I move towards my own theme, for config's sake.

This should also help as I start moving more and more things into the theme that ... not everyone will want on by default.

Current qualms with the number of option rows are unfortunately blocked by the lack of other viable input methods (e.g. touchscreen, mouse).

ianklatzco commented 5 years ago

Can you elaborate? What sorts of things are you moving into the theme-side? Where are you moving them from?

andrewipark commented 5 years ago

announcer voices, cue for low life, etc. (its not really clear yet but nothing super major)

ianklatzco commented 5 years ago

Where are you moving them from? Where are you moving them to?

Is this options menu right before a song vs. the operator menu?

andrewipark commented 5 years ago

new toggles for previously untoggleable behavior

ianklatzco commented 5 years ago

i see. shouldn't this be upstream?

andrewipark commented 5 years ago

i see. shouldn't this be upstream?

Current qualms with the number of option rows

Multiple PRs with toggle-ables have been blocked. This is for valid reasons, but I have slightly different opinions on what level of options exposure is acceptable.

andrewipark commented 5 years ago

This issue is too broad.