search

ddshelt / ddshelt.github.io

0 stars 0 forks source link

index.html - a few small updates #1

Open nicksuch opened 6 years ago

nicksuch commented 6 years ago

Hey @ddshelt ! Your index page looks great! Here are a few small tweaks under the hood to make it even better:

  1. The <center> tag, while still rendered by most web browsers, is now considered obsolete. Centering things like images in HTML / CSS is surprisingly complex, but there are a few better ways of doing it.

  2. Make sure elements are properly nested. Your <center> element and overlaps with your <div> element.

  3. Your <img> is missing an alt tag. These are helpful to make your image more accessible to all users, and to help search engines to better identify them.

  4. Your social links have extra </li> tags, but doesn't look like they're part of a list.

Again, this is a great first pass, just a few things to make your HTML fully standards-compliant. If you ever want to check this on your own, you can use this tool: https://validator.w3.org/

ddshelt commented 6 years ago

Thanks for the feedback! I will correct my mistakes tonight while I’m finishing up the 3rd challenge.

On Thu, Sep 6, 2018 at 5:13 PM Nick Such notifications@github.com wrote:

Hey @ddshelt https://github.com/ddshelt ! Your index page looks great! Here are a few small tweaks under the hood to make it even better:

1.

The

tag, while still rendered by most web browsers, is now considered obsolete. Centering things like images in HTML / CSS is surprisingly complex, but there are a few better ways of doing it https://css-tricks.com/centering-css-complete-guide/. 2.

Make sure elements are properly nested http://www.bu.edu/tech/services/cccs/websites/www/non-wordpress/start/html-introduction/syntax/nesting-tags/. Your

element and overlaps with your
element. 3.

Your is missing an alt tag. These are helpful to make your image more accessible to all users, and to help search engines to better identify them. 4.

Your social links have extra tags, but doesn't look like they're part of a list.

Again, this is a great first pass, just a few things to make your HTML fully standards-compliant. If you ever want to check this on your own, you can use this tool: https://validator.w3.org/

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ddshelt/ddshelt.github.io/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/AofMvQnfnvEt_oSQOY7KpQWIAMrgo-28ks5uYY_egaJpZM4WdudT .