search

ddsjoberg / dcurves

Decision Curve Analysis
http://www.danieldsjoberg.com/dcurves/
Other
37 stars 14 forks source link

reordered to match ordering of statistics in table #10

Closed ltin1214 closed 2 years ago

ltin1214 commented 2 years ago

@ddsjoberg Calculation of the statistics are 100% correct. I got lost down a rabbit hole when I was comparing the final results and some manual calculations, which was completely my own fault because I had assumed the statistics would be in the same order as the nifty table of available statistics. Therefore, would suggest reordering to match that table.

ddsjoberg commented 2 years ago

oh goodness! i didn't realize this comment was in a PR, and I made the same change in the original PR branch!

PS Pull request into a pull request....that is master level gitting!

ltin1214 commented 2 years ago

Lol if GitHub desktop wasn't so excellent about suggesting the fork, I was going to old school just send the changed files.

On Wed, May 25, 2022, 17:00 Daniel Sjoberg @.***> wrote:

Closed #10 https://github.com/ddsjoberg/dcurves/pull/10.

— Reply to this email directly, view it on GitHub https://github.com/ddsjoberg/dcurves/pull/10#event-6681092544, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALYHSNNY2YEZBSRVUTYCEXDVL2IGPANCNFSM5W56YCJQ . You are receiving this because you authored the thread.Message ID: @.***>