ddsjoberg / gtsummary

Presentation-Ready Data Summary and Analytic Result Tables
http://www.danieldsjoberg.com/gtsummary
Other
1.04k stars 114 forks source link

v2.0 add unit-tests for tbl_survfit for add_n, add_nevent, add_p #1753

Closed zdz2101 closed 2 months ago

zdz2101 commented 3 months ago

What changes are proposed in this pull request?

If there is an GitHub issue associated with this pull request, please provide link.


Reviewer Checklist (if item does not apply, mark is as complete)

When the branch is ready to be merged into master:

ddsjoberg commented 3 months ago

@zdz2101 is this ready for review?

zdz2101 commented 3 months ago

@zdz2101 is this ready for review?

Ahh yes I forgot to assign you, this is ready!

ddsjoberg commented 3 months ago

Hey! I am going to hold off reviewing these updates until we get the tests for tbl_survfit() merged. If it happens we have to make changes to the primary function, that may cause downstream issues in these fns.

zdz2101 commented 2 months ago

Closing in favor of of #1838