Closed zdz2101 closed 2 months ago
@zdz2101 is this ready for review?
@zdz2101 is this ready for review?
Ahh yes I forgot to assign you, this is ready!
Hey! I am going to hold off reviewing these updates until we get the tests for tbl_survfit()
merged. If it happens we have to make changes to the primary function, that may cause downstream issues in these fns.
Closing in favor of of #1838
What changes are proposed in this pull request?
If there is an GitHub issue associated with this pull request, please provide link.
Reviewer Checklist (if item does not apply, mark is as complete)
renv::install()
tbl_summary()
, was the same change implemented fortbl_svysummary()
?_pkgdown.yml
pkgdown::build_site()
. Check the R console for errors, and review the rendered website.withr::with_envvar(new = c("NOT_CRAN" = "true"), covr::report())
. Begin in a fresh R session without any packages loaded.usethis::use_spell_check()
runs with no spelling errors in documentationWhen the branch is ready to be merged into master:
NEWS.md
with the changes from this pull request under the heading "# gtsummary (development version)
". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).usethis::use_version(which = "dev")
codemetar::write_codemeta()
usethis::use_spell_check()
again