search

ddsol / speedtest.net

node.js SpeedTest.net client module
MIT License
607 stars 126 forks source link

Fix #117: license info throwing error and breaking Promise #118

Closed kitsunekyo closed 3 years ago

kitsunekyo commented 3 years ago

This fixes #117

The regex check on line 279 never stuck, due to it testing for \n, instead of the escaped string version.

Changes:

Reproduce: use vscode ms-vscode-remote.remote-containers extension, to run it in a fresh container -> this will require accepting the license, and throw the error.

I've added a temporary run.js locally, where I execute the package and attach to it via node debugger in vscode. (breakpoint line 277). Then its fairly clear that the regex that supposedly should clear the error, does not work.

kitsunekyo commented 3 years ago

@ddsol is anything missing, for it to get fixed? happy to help out