search

ddssff / cabal-debian

Create a Debianization by examining a .cabal file.
Other
16 stars 10 forks source link

cabal-debian’s test suite broken? #46

Closed nomeata closed 9 years ago

nomeata commented 9 years ago

I just noticed that running cabal test in cabal-debian’s repository will say 

Test suite cabal-debian-tests: PASS

but the log (visible with cabal test --show-details=streaming) lists lots of things that look like failures, e.g.

### Failure in: Debianization Tests:2:test6 - test-data/artvaluereport2
test6 - test-data/artvaluereport2
expected: (ExitSuccess,"","")
 but got: (ExitSuccess,"--- old/debian/artvaluereport2-production.install\n+++ new/debian/artvaluereport2-production.install\n@@\n Clouds.jpg usr/share/ArtValueReport/.\n DataTables-1.8.2 usr/share/ArtValueReport/.\n Udon.js usr/share/ArtValueReport/.\n blueprint usr/share/ArtValueReport/.\n-debian/cabalInstall/7e4b5d8641f6fae99e9ae9b2d8893bc7/my.appraisalreportonline.com /etc/apache2/sites-available/\n+debian/cabalInstall/7e4b5d8641f6fae99e9ae9b2d8893bc7/my.appraisalreportonline.com.conf /etc/apache2/sites-available/\n@@\n flexbox.css usr/share/ArtValueReport/.\n html5sortable usr/share/ArtValueReport/.\n--- old/debian/artvaluereport2-production.links\n+++ new/debian/artvaluereport2-production.links\n@@\n-/etc/apache2/sites-available/my.appraisalreportonline.com /etc/apache2/sites-enabled/my.appraisalreportonline.com\n+/etc/apache2/sites-available/my.appraisalreportonline.com.conf /etc/apache2/sites-enabled/my.appraisalreportonline.com.conf\n \ndebian/cabalInstall/7e4b5d8641f6fae99e9ae9b2d8893bc7/my.appraisalreportonline.com: Deleted\ndebian/cabalInstall/7e4b5d8641f6fae99e9ae9b2d8893bc7/my.appraisalreportonline.com.conf: Created\n | <VirtualHost *:80>\n |     ServerAdmin logic@seereason.com\n |     ServerName www.my.appraisalreportonline.com\n |     ServerAlias my.appraisalreportonline.com\n | \n |     ErrorLog /var/log/apache2/artvaluereport2-production/error.log\n |     CustomLog /var/log/apache2/artvaluereport2-production/access.log combined\n | \n |     ProxyRequests Off\n |     AllowEncodedSlashes NoDecode\n | \n |     <Proxy *>\n |                 AddDefaultCharset off\n |                 Order deny,allow\n |                 #Allow from .example.com\n |                 Deny from all\n |                 #Allow from all\n |     </Proxy>\n | \n |     <Proxy http://127.0.0.1:9027/*>\n |                 AddDefaultCharset off\n |                 Order deny,allow\n |                 #Allow from .example.com\n |                 #Deny from all\n |                 Allow from all\n |     </Proxy>\n | \n |     SetEnv proxy-sendcl 1\n | \n |     ProxyPass / http://127.0.0.1:9027/ nocanon\n |     ProxyPassReverse / http://127.0.0.1:9027/\n | </VirtualHost>\n--- old/debian/control\n+++ new/debian/control\n@@\n  libghc-network-dev (>= 2.4),\n  libghc-network-prof (>= 2.4),\n+ libghc-old-locale-dev,\n+ libghc-old-locale-prof,\n+ libghc-old-time-dev,\n+ libghc-old-time-prof,\n@@\n  libghc-pandoc-dev,\n  libghc-pandoc-prof,\n@@\n  libghc-mtl-doc,\n  libghc-network-doc,\n+ libghc-old-locale-doc,\n+ libghc-old-time-doc,\n@@\n  libghc-pandoc-doc,\n  libghc-parsec3-doc (>= 3) | libghc-parsec2-doc (<< 3),\n","")

Is cabal-debian’s test suite in a working and reliable state at the moment?

ddssff commented 9 years ago

Not quite. I will have to look at that.

ddssff commented 9 years ago

This may only pass when run with ghc-7.10

ddssff commented 9 years ago

Reopening - apparently the exit code of the test suite does not correctly reflect its results.

nomeata commented 9 years ago

In order to not only contribute issues, but also code, I fixed this.

ddssff commented 9 years ago

This is a terrible test suite (I can say this because I wrote it.) I'm tempted to mark it Buildable: False. Its success is very dependent on the exact version of ghc and of many of the library packages that happen to be installed when it runs.