Make panel icon symbolic

ddterm / gnome-shell-extension-ddterm

Another drop down terminal extension for GNOME Shell. With tabs. Works on Wayland natively

https://extensions.gnome.org/extension/3780/ddterm/

GNU General Public License v3.0

291 stars 26 forks source link

Make panel icon symbolic #323

Closed pesader closed 4 months ago

pesader commented 1 year ago

On some third-party icon themes the current panel icon doesn't look like an icon you would typically find in the panel but do provide an icon that does. Here's an example with the very popular Papirus icon theme:

`utilities-terminal`	`utilities-terminal-symbolic`

I would be nice to be able to configure that in the Panel preferences.

amezin commented 9 months ago

Hm... Should the icon always be utilities-terminal-symbolic? (or is there some weird way to apply -symbolic automagically, like in https://github.com/ddterm/gnome-shell-extension-ddterm/blob/master/ddterm/app/style.css )

zleonov commented 5 months ago

Hi @amezin, first just wanted to say what a cool extension. I use it often.

I came here to make a feature request and I see that it is already here.

1) The default icon should always be utilities-terminal-symbolic, I manually change it in panelicon.js 2) It should be configurable in the settings.

This look out of place: ddterm-regular

This looks correct: ddterm-symbolic

amezin commented 5 months ago

https://github.com/GNOME/gnome-shell/blob/69ec2156bf068621eab3840e51fbf7f66227084d/data/theme/gnome-shell-sass/widgets/_panel.scss#L35 "symbolic" icon style can be applied with css, just like in Gtk.

It should be an option (checkbox) - because, for example, appindicator icons aren't "symbolic".

I'm not sure if the ability to override the icon name is actually necessary.

Anyway, there seems to be no tricky/non-trivial logic, pull requests are welcome.