Update to Swift 4 - Githubissues

dduan / Just

Swift HTTP for Humans

MIT License

1.4k stars 134 forks source link

Update to Swift 4 #83

Closed saagarjha closed 7 years ago

saagarjha commented 7 years ago

Just a minor tweaks to get it compile in Swift 4 due to changes made by SE-0154.

saagarjha commented 7 years ago

Hmm…it looks like the build is failing because swift build --clean was deprecated and removed. @dduan Would you like me to update DistributionTests?

dduan commented 7 years ago

Hi @saagarjha thanks for the PR! Do you mind dropping the changes in Just.xcodeproj/xcshareddata/xcschemes/Just.xcscheme and Just.xcodeproj/project.pbxproj? We need to bump the language version number here.

saagarjha commented 7 years ago

Oh, I didn't notice the xcconfig. Let me fix it.

EDIT: @dduan Should I drop all the changes, or just the ones pertaining to SWIFT_VERSION?

saagarjha commented 7 years ago

Thanks!