ddubrava / angular-yandex-maps

🗺️ Yandex.Maps Angular components that implement the Yandex.Maps JavaScript API
https://ddubrava.github.io/angular8-yandex-maps/#/
MIT License
57 stars 7 forks source link

feat: support Yandex.Maps v3 #238

Closed ddubrava closed 2 months ago

ddubrava commented 3 months ago

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Closes #226

What is the new behavior?

Only v2 is supported

Does this PR introduce a breaking change?

ddubrava commented 3 months ago

Working on this. There are a lot of changes, so it will take a few months

ddubrava commented 2 months ago

Layers should be components

https://yandex.com/dev/jsapi30/doc/ru/dg/concepts/integrations/reactify

<YMap location={{center: [25.229762, 55.289311], zoom: 9}} mode="vector">
  <YMapDefaultSchemeLayer />
  <YMapDefaultFeaturesLayer />

  <YMapMarker coordinates={[25.229762, 55.289311]} draggable={true}>
    <section>
      <h1>You can drag this header</h1>
    </section>
  </YMapMarker>
</YMap>
ddubrava commented 2 months ago

Migrate to standalone

ddubrava commented 2 months ago

https://yandex-maps-unofficial.github.io/vue-yandex-maps/components/marker.html

ddubrava commented 2 months ago

It's a very first version, so there is a small amount of components. I just want to publish the first version

ddubrava commented 2 months ago

Fix codecov, update docs.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 99.13043% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.64%. Comparing base (1936c6a) to head (bc6bcd7). Report is 3 commits behind head on main.

Files Patch % Lines
.../angular-yandex-maps-v3/src/lib/tokens/y-config.ts 60.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #238 +/- ## ========================================== + Coverage 98.47% 98.64% +0.16% ========================================== Files 14 24 +10 Lines 657 887 +230 Branches 72 89 +17 ========================================== + Hits 647 875 +228 - Misses 4 6 +2 Partials 6 6 ``` | [Flag](https://app.codecov.io/gh/ddubrava/angular-yandex-maps/pull/238/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniil+Dubrava) | Coverage Δ | | |---|---|---| | [angular-yandex-maps-v2](https://app.codecov.io/gh/ddubrava/angular-yandex-maps/pull/238/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniil+Dubrava) | `98.47% <ø> (?)` | | | [angular-yandex-maps-v3](https://app.codecov.io/gh/ddubrava/angular-yandex-maps/pull/238/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniil+Dubrava) | `99.13% <99.13%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniil+Dubrava#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ddubrava commented 2 months ago

Mention that types should be installed. Cannot find module '@yandex/ymaps3-types' or its corresponding type declarations.

ddubrava commented 2 months ago

Without OnPush there are tons of ticks in v3. Figure out why

upd: create a map outside an angular zone

ddubrava commented 2 months ago

YMapDefaultMarker breaks a toggle language feature

upd: __chunk_yandex_ymaps3 should be deleted before updating a configuration

ddubrava commented 2 months ago

Rename repo from angular8-yandex-maps to angular-yandex-maps after merge. Don't do it before since it breaks all the links to the documentation