Closed ddubrava closed 1 month ago
Attention: Patch coverage is 79.41176%
with 7 lines
in your changes missing coverage. Please review.
Project coverage is 97.50%. Comparing base (
7aedbcf
) to head (0a24d3f
).
Files | Patch % | Lines |
---|---|---|
.../angular-yandex-maps-v3/src/lib/utils/zone/zone.ts | 45.45% | 6 Missing :warning: |
.../angular-yandex-maps-v2/src/lib/utils/zone/zone.ts | 90.90% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
ngOnChanges -> setLocation -> still causes a lot of ticks. It seems that we need somehow to disconnect the library code from zones. runOutside doesn't help in some cases
What kind of change does this PR introduce?
Which library does this PR affect?
What is the current behavior?
All third-party components must be outside an Angular zone because there is no reason to run them inside. The libraries mutate the DOM on their own, and they do not need ticks (change detections).
YaApiLoaderService
is implicitly outside a zoneYApiLoaderService
is in a zone, all components are also created in a zoneSo we need to add
exitZone
explicitly to the services.What is the new behavior?
All components are created outside an Angular zone.
Does this PR introduce a breaking change?