ddugovic / Stockfish

Retired multi-variant fork of popular UCI chess engine; please use Fairy-Stockfish instead
https://github.com/ianfab/Fairy-Stockfish
GNU General Public License v3.0
132 stars 44 forks source link

Status of bughouse #524

Closed niklasf closed 6 years ago

niklasf commented 6 years ago

Looking for other compiler flags, I see that -DBUGHOUSE is enabled by default. What's the status of the implementation? Maybe it should be disabled by default or moved entirely to a seperate branch?

ddugovic commented 6 years ago

Multi-Variant Stockfish has a working bughouse implementation (captured pieces are not added to the player's hand) with minimal code complexity:

$ grep -n bughouse *.cpp *.h
position.cpp:1376:              if (! is_bughouse())
position.cpp:1392:          if (! is_bughouse())
position.cpp:1774:              if (! is_bughouse())
position.h:204:  bool is_bughouse() const;
position.h:827:inline bool Position::is_bughouse() const {
types.h:214:"bughouse",

But I suppose if nobody's using it (UCI might not even support features people think necessary to properly play bughouse) maybe it should be disabled by default.

niklasf commented 6 years ago

Ah, never mind then. I thought it wasn't even working.