ddvk / remarkable2-framebuffer

remarkable2 framebuffer reversing
MIT License
283 stars 22 forks source link

Use previous config if version not found #103

Closed rotech closed 2 years ago

rotech commented 2 years ago

Often the small incremental changes from Remarkable in the beta channel don't alter the offsets, and the first thing people often try is to use the previous version config. This is just a quick change to attempt to use the previous version offsets if none are found.

Definitely need someone else to do some more thinking behind this, as I'm really not accross the whole code base and any unintended consequences. But I thought it was worth the discussion?

matteodelabre commented 2 years ago

This is an interesting idea, but what if the offsets actually change in the next version? One can only imagine what replacing random code from Xochitl could cause.

rotech commented 2 years ago

Yeah, instead of failing nicely and saying version not supported, best-case scenario is a crash. Probably only useful for people getting the beta releases who want to roll the dice on being up and running a bit quicker.