ddvk / remarkable2-framebuffer

remarkable2 framebuffer reversing
MIT License
279 stars 22 forks source link

Segmentation fault with version 0.0.6 #68

Closed juanfcocontreras closed 3 years ago

juanfcocontreras commented 3 years ago

I just upgraded my Remarkable to version 2.9.0.210 and remarkable2-framebuffer to version 0.0.6 which is supposed to be compatible, but I get:

308 Segmentation fault

However, with the previous version emarkable2-framebuffer 0.0.5 I have no problems with version 2.9.0.210 of my Remarkable.

matteodelabre commented 3 years ago

Hi! Thanks for the report. I’m trying to reproduce your issue, but I’m going to need more details:

Also, I’m surprised you’re able to use 0.0.5 on OS 2.9.0.210, since it’s failing to find signatures for me:

$ LD_PRELOAD=/home/root/librm2fb_client.so.1.0.1 /usr/bin/xochitl
Unable to find update_fn
PLEASE SEE https://github.com/ddvk/remarkable2-framebuffer/issues/18
$ LD_PRELOAD=/home/root/librm2fb_server.so.1.0.1 /usr/bin/xochitl
STARTING RM2FB
BIN FILE: /usr/bin/xochitl
COULDNT LOCATE SIGNATURE IN /usr/bin/xochitl
PLEASE SEE https://github.com/ddvk/remarkable2-framebuffer/issues/18
juanfcocontreras commented 3 years ago

Thank you for your interest.

* Did you build remarkable2-framebuffer manually or did you install it from Toltec?

I downloaded it directly from the releases of this repository.

* What exact command did you run to get the segfault?

I'm using remarkable2-framebuffer to get koreader working using the following repository:

https://github.com/ddvk/remarkable-autoinstall/tree/master/rm2

Launching the script ~/scripts/ko.sh I got the exception.

Eeems commented 3 years ago

Looks like remarkable-autoinstall was never updated to use xochitl as the server and is still using remarkable-shutdown:

https://github.com/ddvk/remarkable-autoinstall/blob/master/rm2/scripts/ko.sh#L11

Edit: It also looks like @juanfcocontreras also opened an issue about this: https://github.com/ddvk/remarkable-autoinstall/issues/17

matteodelabre commented 3 years ago

Also, the auto_rm2.sh script is fetching rm2fb release 0.0.2, so I’m assuming you have modified it to make it work?

juanfcocontreras commented 3 years ago

Also, the auto_rm2.sh script is fetching rm2fb release 0.0.2, so I’m assuming you have modified it to make it work?

Yes, that's just what I was going to comment on. I'm manually updating every version, and this is the first time I'm having problems.

matteodelabre commented 3 years ago

Just tested Toltec’s KOReader package with rm2fb 0.0.6 and there’s no segfault, so this seems to come from the autoinstall script.

juanfcocontreras commented 3 years ago

Looks like remarkable-autoinstall was never updated to use xochitl as the server and is still using remarkable-shutdown:

https://github.com/ddvk/remarkable-autoinstall/blob/master/rm2/scripts/ko.sh#L11

Edit: It also looks like @juanfcocontreras also opened an issue about this: ddvk/remarkable-autoinstall#17

Exactly, the complete error trace is:

./scripts/ko.sh: line 12:   435 Segmentation fault      LD_PRELOAD=/home/root/librm2fb_server.so.1.0.1 /usr/bin/rm_shutdown
matteodelabre commented 3 years ago

Can you try replacing /usr/bin/rm_shutdown with /usr/bin/xochitl in the script? (Edit: This fixed the segfault, for me at least.)

juanfcocontreras commented 3 years ago

Can you try replacing /usr/bin/rm_shutdown with /usr/bin/xochitl in the script?

Sure, and it seems to be working great! Thanks a lot!

Just one more question. The script contains several calls to rm_shutdown, including checks whether the process is active in order to kill it. I have changed absolutely everything and it seems to work, but if you understand the script better, could you confirm that it is correct?

Thanks in advance.

juanfcocontreras commented 3 years ago

I just saw that @Eeems eems is making a pull request that fixes these problems. Thank you very much!

Just commenting on the same question I just asked to @matteodelabre , there are more references to remarkable-shutdown (rm-shutdown) in that script. They should all be changed, right?

Eeems commented 3 years ago

I just saw that @Eeems eems is making a pull request that fixes these problems. Thank you very much!

Just commenting on the same question I just asked to @matteodelabre , there are more references to remarkable-shutdown (rm-shutdown) in that script. They should all be changed, right?

Correct, I'm writing the changes now.

matteodelabre commented 3 years ago

Just one more question. The script contains several calls to rm_shutdown, including checks whether the process is active in order to kill it. I have changed absolutely everything and it seems to work, but if you understand the script better, could you confirm that it is correct?

You should replace references to /usr/bin/remarkable-shutdown with /usr/bin/xochitl and remarkable-shutdown with rm2fb-server (using xochitl may work, but will probably also kill the real Xochitl).

Eeems commented 3 years ago

(using xochitl may work, but will probably also kill the real Xochitl).

You'd be correct, if you don't have $NO_XO set, it will kill the real xochitl instance. I'm working on handling that.

matteodelabre commented 3 years ago

Thanks for working on the PR! I’m closing this since it’s not directly caused by rm2fb.

Eeems commented 3 years ago

@juanfcocontreras the PR is ready I think? Would you be willing to test?

juanfcocontreras commented 3 years ago

Sure, I leave my comments in the PR. Thanks to @matteodelabre

matteodelabre commented 3 years ago

Happy to help!