ddvk / rmfakecloud

host your own cloud for the remarkable
GNU Affero General Public License v3.0
705 stars 57 forks source link

unannotated document pages dropped in exported pdf #228

Open wuschel-brompf opened 1 year ago

wuschel-brompf commented 1 year ago

RM on 2.15.1.1189 docker tag 0.0.13

Example

Problem Description

When annotating n pages in a multipage pdf, exported pdf has the FIRST n pages of the source pdf as background (irrespective of which pages were annotated) and overlays them with the annotations made.

Once a page is annotated, and even if the annotation is deleted immediately, it will be counted as an annotated page.

Suggested (dirty) fix

Add and remove an annotation to every page automatically.

related issue

When there are more annotated pages (eg by adding note pages) than pages in the source pdf, "invalid page number (page count too short)" error occurs, see #185

ddvk commented 1 year ago

problably to do with the redirection, or something

wuschel-brompf commented 1 year ago

what do you mean - is this a general issue or an error in my setup?

ddvk commented 1 year ago

I was not clear enough, at some point page redirection was introduced in note files. It got implemented in rmapi, but I haven't tested whether it got updated here.