Open smlombardi opened 10 years ago
When you pressed cmd+j in second time, you need choose text layer (5:10:5:10) instead BG.
Aha! Thanks. It does indeed work.
On Mon, Apr 14, 2014 at 9:49 AM, ddwht notifications@github.com wrote:
When you pressed cmd+j in second time, you need choose text layer (5:10:5:10) instead BG.
— Reply to this email directly or view it on GitHubhttps://github.com/ddwht/sketch-dynamic-button/issues/2#issuecomment-40367109 .
It's broken in the latest beta version of Sketch (3.0.2).
This might be because in Sketch 3.0.2 they migrated from JSTalk to CocoaScript. More info: https://github.com/sketchplugins/cocoascript-migration
Thank you for your feedback. I try to fix it as soon as possible.
@ddwht Thanks! I was wondering why it wasn't working in Sketch 3.0.1. Looking forward to your fix!
Looking forward to the 3.0.2 fix :+1: Thank you for the wonderful plugin.
To update for Sketch 3.0.2, change lines 11-12 to:
for (var i=0; i<groupLayers.count(); i++) {
var layer = [groupLayers objectAtIndex:i];
Not working in Sketch Beta Version 3.1 The initial cmd+j and padding works but when i edit the text in the layer, the text label (eg 5:5:5:5) in the layers list is lost replaced with my edited text. So when i run the plugin again with cmd+j the whole thing is reset.
Thank you for reply, i'll try fix it recently.
@ddwht Is there an eta for sketch 3.1 support?
Does not work on Sketch 3.3 :(
Right, on Sketch 3.3 it just renames your text layer to "0:0:0:0" and creates an emtpy "flex button" group at the same level. HOWEVER, you can rebuild the structure manually: move the "0:0:0:0" text layer in the "flex button" folder, then add a rectangle and name it "BG" (case sensitive). From then on, the plugin will work.
When will be there a Fix for Sketch 3.3? I worked a lot with your Plugin and do it manually is really a pain in the a**, if i have more then 100 Buttons. ;-)
Did you try to download new version? It's already work with 3.3
Sorry my fault! Sketch Toolbox didn't updated the Plugin…
Downloaded and installed latest but still not working. I'm using Sketch V 3.3.2. When I select text and run the plugin, it doesn't create a folder or a background shape. It does change the name of the text layer to 0,0,0,0. It also repositions the layer to the top left of the art-board. Do you know when there will be a working version of Dynamic-Button for V 3.3.2? Thanks!
Works perfectly here, w/ Sketch 3.3.2. Also, @matthewalandaniels : I'm not the developer ;)
@matthewalandaniels It's working. If you use «Sketch Toolbox» you have to remove and install it again. Sometimes it doesn't update it automatically.
Hey, it seems like it's not working on version 3.4.2. The padding moves back to 0:0:0:0 whenever I click on cmd+J for the second time. Any fix?
I'm experiencing the same issue as Gabszanto.
Same error here, I always got a Dynamic group folder with no BG.
Yes, I get the exact "Dynamic group" folder with no BG box (using Sketch 3.6.1)
Yes, I get the same issue now. Using Sketch(3.7.2), there is no BG layer after did the cmd + J.
I also have this issue. Using Sketch Beta Version 3.8 (29681)
See animated gif below. Unless I am using it wrong.