search

ddwht / sketch-dynamic-button

Dynamic button plugin for Sketch.app
1.05k stars 57 forks source link

Loosing padding when renaming button label #29

Open fabnoe opened 8 years ago

fabnoe commented 8 years ago

If I rename a button labels the layer-name is changed too. Thats why the padding info e.g. 10:20:10:20 is changed to "new label" and the plugin does not work any longer.

Is this my fault or a bug? I am using Sketch Version 3.4.2

marcofrasson commented 8 years ago

Yeah, me too with the same problem

ryenski commented 8 years ago

Me too... Sketch Relabel Button seems to do the job

ohelyse commented 8 years ago

Same here... love this plugin! Please fix!

myklee commented 8 years ago

Thanks for the sketch relabel button. It actually works a lot better than dynamic button.

JesseBilsten commented 8 years ago

Same problem.

wwwanyu commented 8 years ago

Same problem here, hope this can be fixed, i like this plugin.

myklee commented 8 years ago

@JesseBilsten @bananapple you guys should try https://github.com/kenmoore/Sketch-Relabel-Button It works really well and is actually more flexible I think.

wwwanyu commented 8 years ago

@myklee just installed it, it works for me, thanks!

JesseBilsten commented 8 years ago

I use both plugins. The relabel button works great for buttons that are horizontally laid out and the type is not set to a specific width. This dynamic button works well for buttons that have a specific width for the type layer and may break to two lines.

I do still run into this bug on a few of my documents and Sketch has said that they fixed the type layer renaming bug, but like I said, I still see it from time to time (and as recent as yesterday).