ddwht / sketch-dynamic-button

Dynamic button plugin for Sketch.app
1.05k stars 57 forks source link

3.5 update issue #30

Open fuggfuggfugg opened 8 years ago

fuggfuggfugg commented 8 years ago

Hi, first time installing a plugin. I just updated to 3.5 and installed the plugin via sketch toolbox. I tried this plugin for the first time and doesn't seem to work.

screen shot 2016-01-26 at 10 01 25 pm

mikeprecious commented 8 years ago

I've been using the plugin for a while. The 3.5 update seems to have created an incompatibility with this plugin. I'm getting the same results you shared.

octavioamu commented 8 years ago

Same error here version 3.5.1 (25234)

donysukardi commented 8 years ago

And I thought I was the only one. Phew..

denswor commented 8 years ago

Dynamic group created without background layer.

When you are updating existing (created in previous version of sketch) dynamic group it works fine.

willian commented 8 years ago

Any news about this?

willian commented 8 years ago

I think this plugin is not maintained anymore, lat commit from April 2015... Do you guys have an alternative?

denswor commented 8 years ago

Well if it's suitable to you, when you are creating Dynamic group with 0:0:0:0 text layer and without BG layer just create a BG layer with Rectangle tool and it will work )

I don't know any alternatives.

wssrstrm commented 8 years ago

I'm not finding this alternative method to work.

mludowise commented 8 years ago

I've had trouble using this plugin since before Sketch 3.5 and switched to sketch-relabel-button: https://github.com/kenmoore/sketch-relabel-button

It's more flexible than Dynamic Button and I'm currently working on a fork to support additional text alignments.

denswor commented 8 years ago

@wssrstrm sorry i don't know what exactly going wrong on your side. this is how it works for me (until it will be fixed by @ddwht )

https://dl.dropboxusercontent.com/u/4616706/sketch-dynamic-button.mov

octavioamu commented 8 years ago

@denswor now I get your alternative I wasn't renaming the bg to BG.

TheDamianHdez commented 8 years ago

Thank you @denswor It helps!

keano12 commented 8 years ago

Yup doesn't work for me either.

soulrider911 commented 8 years ago

same issue here does not work in 3.5

gbrsr commented 8 years ago

Doesn't work with 3.5 for me either (just adding to the pool)

derlewan commented 8 years ago

same issue here does not work in 3.5

fuggfuggfugg commented 8 years ago

@mikeprecious @donysukardi @willian @wssrstrm @mludowise @denswor @octavioamu @TheDamianHdez @keano12 @soulrider911 @gbrsr @derlewan

Greetings Guys, I was the one to log this issue. I took this day and fixed the issue myself. Here is the new repo for you to play around with. The demo video explains how to download and install.

https://github.com/fuggfuggfugg/sketch-dynamic-button-3.5

Enjoy

mikeprecious commented 8 years ago

Works like a charm. Appreciated - thanks!

soulrider911 commented 8 years ago

bingo! Awesome

ambersawaya commented 8 years ago

Thanks @fuggfuggfugg, works great!

fuggfuggfugg commented 8 years ago

@mikeprecious @donysukardi @willian @wssrstrm @mludowise @denswor @octavioamu @TheDamianHdez @keano12 @soulrider911 @gbrsr @derlewan

Greetings again guys, Just a reminder. I've updated my plugin to work with 3.8. You will need to re-install the plugin. Sorry for the inconvenience.

dannyjpwilliams commented 7 years ago

@fuggfuggfugg update for 41.2 anytime soon? Experiencing same error now as before.

fuggfuggfugg commented 7 years ago

@dannyjpwilliams It is working for me. Re-install your plugin, I did some updates day before.

Let me know if it isn't.

dannyjpwilliams commented 7 years ago

Will do! Thanks for the quick reply ☺️.

Cheers!

On Wed, Dec 14, 2016 at 1:18 AM fuggfuggfugg notifications@github.com wrote:

@dannyjpwilliams https://github.com/dannyjpwilliams It is working for me. Re-install your plugin, I did some updates day before.

Let me know if it isn't.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ddwht/sketch-dynamic-button/issues/30#issuecomment-266945206, or mute the thread https://github.com/notifications/unsubscribe-auth/AQbRRv0MyHVM7s7IHWGW9e0cw2kHUMTpks5rH3wZgaJpZM4HNFRY .