ddworken / hishtory

Your shell history: synced, queryable, and in context
https://hishtory.dev
MIT License
2.49k stars 47 forks source link

Warp Terminal support #141

Closed cowboygneox closed 10 months ago

cowboygneox commented 10 months ago

I'm not sure if this is a bug or a feature request, I mostly just want to understand how it works.

I've been trying out Warp. It has its own Ctrl-R integration, fine, but what's weird is that Hishtory can read Warp's command history, but Warp cannot read Hishtory's commands created in a different terminal like iTerm. I'm not sure how Hishtory binds itself to the zsh history, but apparently Warp doesn't work with it.

Any thoughts on how I can debug this, or if this is expected behavior?

ddworken commented 10 months ago

Hmm, interesting. When you say "Warp cannot read Hishtory's commands created in a different terminal like iTerm" do you mean that:

  1. You run a command in iTerm
  2. You press Control+R in Warp
  3. Warp doesn't see the command that you ran in iTerm

If so, this seems like more of a Warp feature request than an issue with hishtory. Hishtory does not impact how the shell normally stores your history (e.g. writing to ~/.bash_history or ~/. zsh_history), which is where I would expect Warp to read entries from. I'll say from playing around with this that it appears as though Warp reads your shell history at startup, but not once started (so if you restart warp after step 1 above, it will work).

ddworken commented 10 months ago

I'm marking this as closed, but if you still are running into issues here that you think could be improved upon by hishtory, please reopen this!