Open de-jcup opened 1 year ago
I did implement a solution at a local branch and it works... but ...
So ... I am really not sure if this should be the way.
I still have to think about this.
At least added the implementation to the feature branch by last commit (so available if still interesting in future)
Situation
It took much effort to get maven tycho build working #371 - at least with asp launcher dependencies etc. the branch für #371 does work locally on my machine, but when removing the installed ASP server jar from user home folder the plugin fails (of course), because the dist jar is no longer available/the lib plugin is not available.
Providing the dist.jar inside editor plugin or lib plugin via Tycho (as before)
One solution would be to provide a lib plugin again with the dist jar inside, but there is a problem with Tycho: It does not simply create a wrapped osgi part for the dist jar (maybe because of the special classifier "dist" ) but only on the dependencies. So adding the dist jar is not so easy.
Another problem here is something that is very odd today: When a user installs n eclipse instances on his/her machine, the user will install the editor plugin and always get a complete ASP server distro inside. Even if the user does NOT want the distro. Also the distro is copied to
~/.eclipse-asciidoctor-editor/libs/$version
(but only one time) and started from there. So we have n+1 locations of the distro jar. This is a waste of memory and also time (always downloaded in a fresh eclipse environment).Wanted
Solution
The ASP server install mechanism will be changed and the dist jar is no longer part of the plugin itself.
The ASP server instances are available at maven central - e.g. Version 1.4.1 is available at https://repo1.maven.org/maven2/de/jcup/asp/asp-server-asciidoctorj/1.4.1/asp-server-asciidoctorj-1.4.1-dist.jar
When the render process is starting, we will now
~/.eclipse-asciidoctor-editor/libs/$version
the plugin will start downloading the version from maven central (https only) at the location.