de-jcup / eclipse-hijson-editor

Highspeed JSON editor
https://marketplace.eclipse.org/content/hijson-editor
Apache License 2.0
8 stars 1 forks source link

Add option to allow unquoted control characters in strings #2

Closed TobiX closed 3 years ago

TobiX commented 4 years ago

I tried to match formatting around the places I changed.

Some other things I noticed:

I might come back with other small changes in the future. Is it okay to put some formatting options into the existing preference pane or should I create a new page? (I don't think we need full-blown formatter profile handling, right?)

TobiX commented 4 years ago

Build error seems the same problem as on master: Travis doesn't have Java 8 anymore...

de-jcup commented 3 years ago

@TobiX : I am so sorry about doing nothing about the PR such a long time - sorry was too busy.

Travis doesn't have Java 8 anymore...

Travis does not support any long oracle....

I fixed this in https://github.com/de-jcup/eclipse-hijson-editor/commit/bd76188c5908be3e1675878066b3f3980315a148 directly at master branch.

de-jcup commented 3 years ago

@TobiX : Thank you very much for the contribution! I appreciate your work and your thoughts.