search

de-jcup / eclipse-jenkins-editor

Jenkins Editor - A eclipse plugin to edit "Jenkinsfile" files
https://marketplace.eclipse.org/content/jenkins-editor
Apache License 2.0
45 stars 5 forks source link

fix: Issue 86 (enhancement) and 87 (bug) #92

Closed BeckerFrank closed 2 years ago

BeckerFrank commented 2 years ago

This review has the fix for #86 (Show up old username and old password when credentials dialog appears) and also the #87 (Pressing cancel button shall not destroy old credentials)

de-jcup commented 2 years ago

Hello @BeckerFrank , thanx for the PR. I will review it in the next days.

de-jcup commented 2 years ago

Your changes do work as long as you are inside the preference page.

But when you close the preferences (even after pressing apply changes) and you reopen the preference dialog and press Credentials... button again, you will have again no data:

image

To have #86 and #87 fixed, the temporary user credential data must be initialized with the current ones (if existing). Please implement this as well.