de-jcup / eclipse-yaml-editor

Eclipse YAML editor
https://marketplace.eclipse.org/content/yaml-editor
Apache License 2.0
35 stars 10 forks source link

Tab replacement not working correct sometimes when folding enabled #62

Open cszabo2 opened 5 years ago

cszabo2 commented 5 years ago

This is a hard to reproduce issue, but when it happens it is very annoying. I have a relatively large (2500 lines) yaml file with long multi-line strings with | and > start chars also double quotes. I installed the yaml editor (restarted Eclipse), then turned on right margin display at 109 chars, set tab sizes to 4 chars, YamlEditors right margin to 109 chars, enabled view whitespace in the general editor. When I did this at first and started to edit the file my insertion point would automatically jump to the end of the file after every Tab press. This happened consistently even after I undid all the settings above, until I closed the file. I tried to make a reduced case by creating a new yaml file to show the problem but was unable to reproduce the problem. I have closed and reopened the file I was originally working on but I was unable to reproduce the problem even after reenabling all the features that may have caused a problem before (BTW this is an Eclipse set up for C++ development not Java, with PyDev and yaml Editor plug-ins added). I filed this issue in an attempt to help find and fix this if others see it and also record the work around (close and reopen the file) in case somebody else sees the same issue.

cszabo2 commented 5 years ago

I found a way to reproduce the issue reliably. Rename the attached file to test.yaml Open it up in Eclipse. In the Outline view Expand V1, Expand V2, select V6. On the left bar collapse cppDoc Click on line 47 and type Tab. The cursor will jump a few lines lowere. test.txt

cszabo2 commented 5 years ago

Apparently the problem appears every time a section of the yaml file is collapsed by clicking the handles on the right of the editor.

de-jcup commented 5 years ago

Hello @cszabo2 image

when pressing just an a it looks like following: image

doing same action with a TAB instead of pressing aon same position leads to: image

Doing same operations in unfolded state or in disabled folding this kind of behaviour does not appear. So it does only appear with folding.

de-jcup commented 5 years ago
root:
  A:
    av1:'av1'
    av2:'av2'
    av2:'av3'

  B:
    bv1:'bv1'
    bv2:'bv2'
    bv3:'bv3'

Brings up same problem with tab and enabled folding: image

image

Also it does not appear when folding is disabled. Also when Collapse all folding triggered, all is working again.

So this is a bug between tab replacement apprach and folding feature...

de-jcup commented 5 years ago

@cszabo2 : I am currently very busy and also concentrating on next bash editor release. So I have no idea when this bug will be fixed - sorry. (Also I am worried the fix will not be easy)

But in the meantime as a workaround you can do following: