search

de-yi / pe

0 stars 0 forks source link

Entities in sequence diagrams should be instances #11

Open de-yi opened 1 year ago

de-yi commented 1 year ago

Entities in this sequence diagram should be either in ":Ui" format or indicate that they are class level entities by using < class > keyword!

Screen Shot 2023-04-14 at 5.27.29 PM.png

soc-pe-bot commented 1 year ago

Team's Response

The entities (or classes) shown are static classes, therefore we wouldn't want to use the ":" colon for our entities.

Feel free to ask if you have any comments, thank you!

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]

If those were static classes, it should have had sign as mentioned in the module website.

Screen Shot 2023-04-20 at 9.09.48 PM.png

Therefore I believe this can still be considered as a bug.