de4a-eu / de4a-commons

DE4A WP5 Shared software components
Apache License 2.0
0 stars 1 forks source link

DE4AMarshaller with messages including canonical evidences #5

Closed aosunacab closed 3 years ago

aosunacab commented 3 years ago

Hi,

I am trying to use unmarshaller: eu.de4a.iem.xml.de4a.DE4AMarshaller.doImResponseMarshaller(aCanonicalEvidenceType)

In order to make conversions with ResponseExtractEvidenceType. My problem is, IDE4ACanonicalEvidenceType rigth now it is not populated with the canonical evidences, so it is not possible to make conversions because, even if you reimplement the marshaller with external canonical evidence XSD, JAXB does not maintains referenced classes on his context, so it throw an error. At this point, I have two questions:

Sorry in advance if I am missing something.

Thanks.

andreasjberg commented 3 years ago

You use the IDE4ACanonicalEvidenceType for the supported CanonicalEvidences from EDE4ACanonicalEvidenceType. You can find an example of it being used in the mock link to it in the code

aosunacab commented 3 years ago

Sure, but the enum only contains: T42_COMPANY_INFO_V04 T42_COMPANY_INFO_V05

phax commented 3 years ago

Correct, because currently we only support the DBA XSDs in 2 different versions. Further canonical evidences will be added while we go. One of the pilot requirements was to have multiple versions of the XSD available in parallel

aosunacab commented 3 years ago

I understand. But we have a test scenario over BirthCertificate canonical evidence. it is not possible to add this evidence?

phax commented 3 years ago

Of course it is possible. Where can we find the XSD?

aosunacab commented 3 years ago

There is nothing official yet, but could be useful to have it, maybe we can add a "temporary" XSD?

phax commented 3 years ago

Sure. Where can I find the temporary XSDs? I can only include what I am aware of :)

aosunacab commented 3 years ago

hehe sure. It is in here: BirthCertificate.xsd Taking adventage of this, de4a-commons could be updated with last changes made by Daniel Castro.

Thanks a lot.

phax commented 3 years ago

Do you know who is the author of this BirthCertificate XSD? I would have some change requests....

aosunacab commented 3 years ago

Myself, it's just a basic schema not going much further. although if you have any improvement or modification, no problem.

phax commented 3 years ago

Okay, I made some changes to the XSD (extracted the type of the root element)

phax commented 3 years ago

@aosunacab what pilot does this XSD belong to? E.g. DBA is for "4.2" - I'd like to keep this assignment in the code

aosunacab commented 3 years ago

I don´t really know, There is no official definition of it, I guess

phax commented 3 years ago

I don't think it is a good idea to introduce an "arbitrary" format for testing. The DBA pilot XSD is simple enough, isn't it?

aosunacab commented 3 years ago

I think it is not a big deal keep a test scheme until an official definition comes. Anyway, it could be possible to update commons project with latest XSDs updates?

phax commented 3 years ago

DBA 0.6 was added

phax commented 3 years ago

I am in the middle of adding the T4.1-UC1 stuff, so I am leaving this open

phax commented 3 years ago

Now the Studying Abroad stuff is contained (T4.1, UC1)