search

de4a-eu / de4a

DE4A WP5 Connector
Apache License 2.0
2 stars 5 forks source link

Catching and loggin an exceptionbut continuing afterwards #28

Closed daffyDukk closed 3 years ago

daffyDukk commented 3 years ago

https://github.com/de4a-wp5/de4a/blob/d47997f6deda975bc61f036432c1494e96ae3276/de4a-connector/src/main/java/eu/de4a/connector/as4/client/DomibusGatewayClient.java#L206

An exception is caught and logged. But operations continue afterwards. Is this intended behavior? It seems somewhat unorthodox to just continue processing responses when there is an exception. Maybe document the intention of the method and why

aosunacab commented 3 years ago

Error handling is not implemeneted yet, even defined. It is a pending task that will cover all exceptions and error handling, with relevant codes, messages, and so on.

daffyDukk commented 3 years ago

I understand that it is not implemented fully yet. This can still create issues when operations just continue. Please document the intended behavior of the method. And what to expect when exceptions are thrown and how it could affect returned values.

Also a documented timeline for when errorhandling could be commented into the code. ie //todo: Errorhandling will be implemented in next version. In the meantime expect yadayadayada. This shows that as a developer you are aware of this and will fix it in an upcoming release. todos are also ususally marked up in most modern IDEs