de4a-eu / de4a

DE4A WP5 Connector
Apache License 2.0
2 stars 5 forks source link

Exception caught but only logged #29

Closed daffyDukk closed 3 years ago

daffyDukk commented 3 years ago

https://github.com/de4a-wp5/de4a/blob/d47997f6deda975bc61f036432c1494e96ae3276/de4a-connector/src/main/java/eu/de4a/connector/as4/client/DomibusGatewayClient.java#L217

Again the exception is caught and logged but operations continue afterwards. In this case two null values could be added to the responseWrapper property. Is this intended behaviour? Seems strange to return a response containing null values? In my opinion nothing should be returned or an error